Fix incorrect override of GetLayoutOrder().
authorNico Weber <thakis@chromium.org>
Wed, 30 Jul 2014 21:16:25 +0000 (14:16 -0700)
committerNico Weber <thakis@chromium.org>
Wed, 30 Jul 2014 21:16:25 +0000 (14:16 -0700)
fsdk_baseform.h:63:19: error: 'CPDFSDK_Widget::GetLayoutOrder' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
        virtual int                                             GetLayoutOrder() {return 2;}
                                                                ^
fsdk_baseannot.h:70:18: note: hidden overloaded virtual function 'CPDFSDK_Annot::GetLayoutOrder' declared here: different qualifiers (const vs none)
        virtual int                                     GetLayoutOrder() const { return 5; }
                                                        ^

On Windows, I believe MSVS treats these as override since it's such a common and
easy mistake, but clang and gcc do what the standard specifies. Add a "const" to
the function in the subclass so that this is actually an override, as intended.

BUG=pdfium:29
R=bo_xu@foxitsoftware.com

Review URL: https://codereview.chromium.org/427173002

fpdfsdk/include/fsdk_baseform.h

index b93cbbd..073c99f 100644 (file)
@@ -60,7 +60,7 @@ public:
 
        int                                                             GetFieldType() const;
        //define layout order to 2.
-       virtual int                                             GetLayoutOrder() {return 2;}
+       virtual int                                             GetLayoutOrder() const {return 2;}
        /*
        FIELDFLAG_READONLY
        FIELDFLAG_REQUIRED