Fix test naming in previous commit.
authorTom Sepez <tsepez@chromium.org>
Fri, 23 Jan 2015 23:22:57 +0000 (15:22 -0800)
committerTom Sepez <tsepez@chromium.org>
Fri, 23 Jan 2015 23:22:57 +0000 (15:22 -0800)
The embeddertests binary should have source files ending in
_embeddertest, not _unittest.

TBR=bo_xu@foxitsoftware.com

Review URL: https://codereview.chromium.org/871093004

BUILD.gn
fpdfsdk/src/fpdf_dataavail_embeddertest.cpp [new file with mode: 0644]
fpdfsdk/src/fpdf_dataavail_unittest.cpp [deleted file]
pdfium.gyp

index 0822a5f..a6ea102 100644 (file)
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -813,7 +813,7 @@ test("pdfium_unittests") {
 
 test("pdfium_embeddertests") {
   sources = [
-    "fpdfsdk/src/fpdf_dataavail_unittest.cpp",
+    "fpdfsdk/src/fpdf_dataavail_embeddertest.cpp",
     "fpdfsdk/src/fpdfdoc_embeddertest.cpp",
     "fpdfsdk/src/fpdfview_embeddertest.cpp",
     "testing/embedder_test.cpp",
diff --git a/fpdfsdk/src/fpdf_dataavail_embeddertest.cpp b/fpdfsdk/src/fpdf_dataavail_embeddertest.cpp
new file mode 100644 (file)
index 0000000..6081fa5
--- /dev/null
@@ -0,0 +1,23 @@
+// Copyright 2015 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "../../testing/embedder_test.h"
+#include "../../fpdfsdk/include/fpdfview.h"
+#include "../../fpdfsdk/include/fpdfdoc.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class FPDFDataAvailEmbeddertest : public EmbedderTest {
+};
+
+TEST_F(FPDFDataAvailEmbeddertest, TrailerUnterminated) {
+  // Document must open without crashing but is too malformed to be available.
+  EXPECT_TRUE(OpenDocument("testing/resources/trailer_unterminated.pdf"));
+  EXPECT_FALSE(FPDFAvail_IsDocAvail(avail_, &hints_));
+}
+
+TEST_F(FPDFDataAvailEmbeddertest, TrailerAsHexstring) {
+  // Document must open without crashing but is too malformed to be available.
+  EXPECT_TRUE(OpenDocument("testing/resources/trailer_as_hexstring.pdf"));
+  EXPECT_FALSE(FPDFAvail_IsDocAvail(avail_, &hints_));
+}
diff --git a/fpdfsdk/src/fpdf_dataavail_unittest.cpp b/fpdfsdk/src/fpdf_dataavail_unittest.cpp
deleted file mode 100644 (file)
index 6081fa5..0000000
+++ /dev/null
@@ -1,23 +0,0 @@
-// Copyright 2015 PDFium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "../../testing/embedder_test.h"
-#include "../../fpdfsdk/include/fpdfview.h"
-#include "../../fpdfsdk/include/fpdfdoc.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-class FPDFDataAvailEmbeddertest : public EmbedderTest {
-};
-
-TEST_F(FPDFDataAvailEmbeddertest, TrailerUnterminated) {
-  // Document must open without crashing but is too malformed to be available.
-  EXPECT_TRUE(OpenDocument("testing/resources/trailer_unterminated.pdf"));
-  EXPECT_FALSE(FPDFAvail_IsDocAvail(avail_, &hints_));
-}
-
-TEST_F(FPDFDataAvailEmbeddertest, TrailerAsHexstring) {
-  // Document must open without crashing but is too malformed to be available.
-  EXPECT_TRUE(OpenDocument("testing/resources/trailer_as_hexstring.pdf"));
-  EXPECT_FALSE(FPDFAvail_IsDocAvail(avail_, &hints_));
-}
index e9c958c..eedbe5d 100644 (file)
         '<(DEPTH)'
       ],
       'sources': [
-        'fpdfsdk/src/fpdf_dataavail_unittest.cpp',
+        'fpdfsdk/src/fpdf_dataavail_embeddertest.cpp',
         'fpdfsdk/src/fpdfdoc_embeddertest.cpp',
         'fpdfsdk/src/fpdfview_embeddertest.cpp',
         'testing/embedder_test.cpp',