Add small flate decode unit test.
authorTom Sepez <tsepez@chromium.org>
Tue, 24 Feb 2015 22:59:35 +0000 (14:59 -0800)
committerTom Sepez <tsepez@chromium.org>
Tue, 24 Feb 2015 22:59:35 +0000 (14:59 -0800)
As we remove flate encoded sections from test cases (to
promote clarity), we should first have a simple unit test
for the underlying functionality.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/845313006

BUILD.gn
core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp [new file with mode: 0644]
pdfium.gyp

index 8409da3..d6268a4 100644 (file)
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -800,6 +800,7 @@ static_library("formfiller") {
 
 test("pdfium_unittests") {
   sources = [
+    "core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp",
     "core/src/fxcrt/fx_basic_bstring_unittest.cpp",
     "core/src/fxcrt/fx_basic_wstring_unittest.cpp",
     "testing/fx_string_testhelpers.cpp",
diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp
new file mode 100644 (file)
index 0000000..18196a1
--- /dev/null
@@ -0,0 +1,98 @@
+// Copyright 2015 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <cstring>
+#include <string>
+
+#include "../../../../fpdfsdk/include/fpdfview.h"
+#include "../../../../testing/fx_string_testhelpers.h"
+#include "../../../include/fxcrt/fx_basic.h"
+#include "../../../include/fpdfapi/fpdf_parser.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+// NOTE: python's zlib.compress() and zlib.decompress() may be useful for
+// external validation of the FlateEncode/FlateDecode test cases.
+
+#define TEST_CASE(input_literal, expected_literal) \
+  { (const unsigned char*)input_literal, sizeof(input_literal) - 1, \
+    (const unsigned char*)expected_literal, sizeof(expected_literal) - 1 }
+
+TEST(ParserDecode, FlateEncode) {
+  struct FlateEncodeCase {
+    const unsigned char* input;
+    unsigned int input_size;
+    const unsigned char* expected;
+    unsigned int expected_size;
+  } flate_encode_cases[] = {
+    TEST_CASE("", "\x78\x9c\x03\x00\x00\x00\x00\x01"),
+    TEST_CASE(" ", "\x78\x9c\x53\x00\x00\x00\x21\x00\x21"),
+    TEST_CASE("123", "\x78\x9c\x33\x34\x32\x06\x00\01\x2d\x00\x97"),
+    TEST_CASE("\x00\xff", "\x78\x9c\x63\xf8\x0f\x00\x01\x01\x01\x00"),
+    TEST_CASE("1 0 0 -1 29 763 cm\n0 0 555 735 re\nW n\nq\n0 0 555 734.394 re\n"
+              "W n\nq\n0.8009 0 0 0.8009 0 0 cm\n1 1 1 RG 1 1 1 rg\n/G0 gs\n"
+              "0 0 693 917 re\nf\nQ\nQ\n"
+              ,
+              "\x78\x9c\x33\x54\x30\x00\x42\x5d\x43\x05\x23\x4b\x05\x73\x33\x63"
+              "\x85\xe4\x5c\x2e\x90\x80\xa9\xa9\xa9\x82\xb9\xb1\xa9\x42\x51\x2a"
+              "\x57\xb8\x42\x1e\x57\x21\x92\xa0\x89\x9e\xb1\xa5\x09\x92\x84\x9e"
+              "\x85\x81\x81\x25\xd8\x14\x24\x26\xd0\x18\x43\x05\x10\x0c\x72\x57"
+              "\x80\x30\x8a\xd2\xb9\xf4\xdd\x0d\x14\xd2\x8b\xc1\x46\x99\x59\x1a"
+              "\x2b\x58\x1a\x9a\x83\x8c\x49\xe3\x0a\x04\x42\x00\x37\x4c\x1b\x42"
+              ),
+  };
+
+  FPDF_InitLibrary();
+  for (size_t i = 0; i < FX_ArraySize(flate_encode_cases); ++i) {
+    FlateEncodeCase* ptr = &flate_encode_cases[i];
+    unsigned char* result;
+    unsigned int result_size;
+    FlateEncode(ptr->input, ptr->input_size, result, result_size); // Leaks.
+    EXPECT_EQ(std::string((const char*)ptr->expected, ptr->expected_size),
+              std::string((const char*)result, result_size))
+        << " for case " << i;
+  }
+  FPDF_DestroyLibrary();
+}
+
+TEST(ParserDecode, FlateDecode) {
+  struct FlateDecodeCase {
+    const unsigned char* input;
+    unsigned int input_size;
+    const unsigned char* expected;
+    unsigned int expected_size;
+  } flate_decode_cases[] = {
+    TEST_CASE("", ""),
+    TEST_CASE("preposterous nonsense", ""),
+    TEST_CASE("\x78\x9c\x03\x00\x00\x00\x00\x01", ""),
+    TEST_CASE("\x78\x9c\x53\x00\x00\x00\x21\x00\x21", " "),
+    TEST_CASE("\x78\x9c\x33\x34\x32\x06\x00\01\x2d\x00\x97", "123"),
+    TEST_CASE("\x78\x9c\x63\xf8\x0f\x00\x01\x01\x01\x00", "\x00\xff"),
+    TEST_CASE("\x78\x9c\x33\x54\x30\x00\x42\x5d\x43\x05\x23\x4b\x05\x73\x33\x63"
+              "\x85\xe4\x5c\x2e\x90\x80\xa9\xa9\xa9\x82\xb9\xb1\xa9\x42\x51\x2a"
+              "\x57\xb8\x42\x1e\x57\x21\x92\xa0\x89\x9e\xb1\xa5\x09\x92\x84\x9e"
+              "\x85\x81\x81\x25\xd8\x14\x24\x26\xd0\x18\x43\x05\x10\x0c\x72\x57"
+              "\x80\x30\x8a\xd2\xb9\xf4\xdd\x0d\x14\xd2\x8b\xc1\x46\x99\x59\x1a"
+              "\x2b\x58\x1a\x9a\x83\x8c\x49\xe3\x0a\x04\x42\x00\x37\x4c\x1b\x42"
+              ,
+              "1 0 0 -1 29 763 cm\n0 0 555 735 re\nW n\nq\n0 0 555 734.394 re\n"
+              "W n\nq\n0.8009 0 0 0.8009 0 0 cm\n1 1 1 RG 1 1 1 rg\n/G0 gs\n"
+              "0 0 693 917 re\nf\nQ\nQ\n"
+              ),
+  };
+
+  FPDF_InitLibrary();
+  for (size_t i = 0; i < FX_ArraySize(flate_decode_cases); ++i) {
+    FlateDecodeCase* ptr = &flate_decode_cases[i];
+    unsigned char* result;
+    unsigned int result_size;
+    FlateDecode(ptr->input, ptr->input_size, result, result_size); // Leaks.
+    EXPECT_EQ(std::string((const char*)ptr->expected, ptr->expected_size),
+              std::string((const char*)result, result_size))
+        << " for case " << i;
+  }
+  FPDF_DestroyLibrary();
+}
+
+
+#undef TEST_CASE
index 15f942d..c1cd724 100644 (file)
         '<(DEPTH)'
       ],
       'sources': [
-        'testing/fx_string_testhelpers.h',
-        'testing/fx_string_testhelpers.cpp',
+        'core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp',
         'core/src/fxcrt/fx_basic_bstring_unittest.cpp',
         'core/src/fxcrt/fx_basic_wstring_unittest.cpp',
+        'testing/fx_string_testhelpers.h',
+        'testing/fx_string_testhelpers.cpp',
       ],
     },
     {