Followup comments from https://codereview.chromium.org/298893007/
authorJohn Abd-El-Malek <jam@chromium.org>
Wed, 28 May 2014 20:35:54 +0000 (13:35 -0700)
committerJohn Abd-El-Malek <jam@chromium.org>
Wed, 28 May 2014 20:35:54 +0000 (13:35 -0700)
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/302653009

build/gyp_pdfium
build/standalone.gypi

index 59f2c6c..7019795 100755 (executable)
@@ -42,5 +42,6 @@ def main():
 
   run_gyp(args)
 
+
 if __name__ == '__main__':
   sys.exit(main())
\ No newline at end of file
index ab84759..3b4f01b 100644 (file)
@@ -37,6 +37,7 @@
       'host_arch%': '<(host_arch)',
       'target_arch%': '<(target_arch)',
     },
+    # These two are needed by V8.
     'host_arch%': '<(host_arch)',
     'target_arch%': '<(target_arch)',
     'werror%': '-Werror',
     'defines!': [
       'DEBUG',
     ],
-    'cflags!': [
+    'cflags': [
       '-Wall',
       '-W',
       '-Wno-unused-parameter',