Merge to XFA: patch from CL 703213004
authorTom Sepez <tsepez@chromium.org>
Thu, 6 Nov 2014 23:03:46 +0000 (15:03 -0800)
committerTom Sepez <tsepez@chromium.org>
Thu, 6 Nov 2014 23:03:46 +0000 (15:03 -0800)
Fix bug with reading from uninitialized variable found by VC++'s /analyze.

The flag variable is conditionally initialized but unconditionally read.

Warning was:
src\fpdfapi\fpdf_page\fpdf_page_pattern.cpp(274) : warning C6001:
Using uninitialized memory 'flag'.

BUG=427616
R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/703213004

Review URL: https://codereview.chromium.org/680173005

core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp

index 467ef9b..4644302 100644 (file)
@@ -266,7 +266,7 @@ CFX_FloatRect _GetShadingBBox(CPDF_Stream* pStream, int type, const CFX_AffineMa
     int full_point_count = type == 7 ? 16 : (type == 6 ? 12 : 1);
     int full_color_count = (type == 6 || type == 7) ? 4 : 1;
     while (!stream.m_BitStream.IsEOF()) {
-        FX_DWORD flag;
+        FX_DWORD flag = 0;
         if (type != 5) {
             flag = stream.GetFlag();
         }