Revert "Pump the v8 message loop in tests"
authorJochen Eisinger <jochen@chromium.org>
Wed, 15 Jul 2015 12:47:01 +0000 (14:47 +0200)
committerJochen Eisinger <jochen@chromium.org>
Wed, 15 Jul 2015 12:47:01 +0000 (14:47 +0200)
This reverts commit 304578020122cc4d2a4a8c1598694ef2b9be92b5.

Turns out that in both cases v8 is already destructed at those points,
and we can't pump the message loops.

TBR=tsepez@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1236603003 .

samples/pdfium_test.cc
testing/embedder_test.cpp

index 8ca26ab..7e9ca68 100644 (file)
@@ -616,8 +616,6 @@ int main(int argc, const char* argv[]) {
     if (!file_contents)
       continue;
     RenderPdf(filename, file_contents, file_length, options);
-    while (v8::platform::PumpMessageLoop(platform, v8::Isolate::GetCurrent()))
-      continue;
     free(file_contents);
   }
 
index 6d9907e..02d0fae 100644 (file)
@@ -173,8 +173,6 @@ void EmbedderTest::TearDown() {
     FPDF_CloseDocument(document_);
     FPDFDOC_ExitFormFillEnvironment(form_handle_);
   }
-  while (v8::platform::PumpMessageLoop(platform_, v8::Isolate::GetCurrent()))
-    continue;
   FPDFAvail_Destroy(avail_);
   FPDF_DestroyLibrary();
   v8::V8::ShutdownPlatform();