Merge to XFA: Corpus tests check for unexpected successes.
authorTom Sepez <tsepez@chromium.org>
Fri, 12 Jun 2015 16:27:46 +0000 (09:27 -0700)
committerTom Sepez <tsepez@chromium.org>
Fri, 12 Jun 2015 16:27:46 +0000 (09:27 -0700)
Original Review URL: https://codereview.chromium.org/1178393002.
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/1184803002.

testing/tools/run_corpus_tests.py
testing/tools/suppressor.py

index 1876581..dbc8f35 100755 (executable)
@@ -55,6 +55,7 @@ def main():
 
   # test files are under .../pdfium/testing/corpus.
   failures = []
+  surprises = []
   walk_from_dir = finder.TestingDir('corpus');
   input_file_re = re.compile('^[a-zA-Z0-9_.]+[.]pdf$')
   for source_dir, _, filename_list in os.walk(walk_from_dir):
@@ -62,11 +63,19 @@ def main():
       if input_file_re.match(input_filename):
          input_path = os.path.join(source_dir, input_filename)
          if os.path.isfile(input_path):
+           result = test_one_file(input_filename, source_dir, working_dir,
+                                  pdfium_test_path, image_differ)
            if test_suppressor.IsSuppressed(input_filename):
-             continue
-         if not test_one_file(input_filename, source_dir, working_dir,
-                              pdfium_test_path, image_differ):
-             failures.append(input_path)
+             if result:
+               surprises.append(input_path)
+           else:
+             if not result:
+               failures.append(input_path)
+
+  if surprises:
+    print '\n\nUnexpected Successes:'
+    for surprise in surprises:
+      print surprise;
 
   if failures:
     print '\n\nSummary of Failures:'
index fff9bc8..2bb3117 100755 (executable)
@@ -24,11 +24,11 @@ class Suppressor:
 
   def IsSuppressed(self, input_filename):
     if input_filename in self.suppression_list:
-      print ("Not running %s, found in %s file" %
+      print ("%s is suppressed, found in %s file" %
              (input_filename, self.SUPPRESSIONS_FILENAME))
       return True
     if input_filename in self.platform_suppression_list:
-      print ("Not running %s, found in %s file" %
+      print ("%s is suppressed, found in %s file" %
              (input_filename, self.PLATFORM_SUPPRESSIONS_FILENAME))
       return True
     return False