Allow FPDFBookmark_GetFirstChild to return the top level bookmark
authorTom Sepez <tsepez@chromium.org>
Fri, 16 Jan 2015 02:14:43 +0000 (18:14 -0800)
committerTom Sepez <tsepez@chromium.org>
Fri, 16 Jan 2015 02:14:43 +0000 (18:14 -0800)
Previously when passing a NULL bookmark to FPDFBookmark_GetFirstChild it returned NULL instead of returning the top level bookmark. This change removes the early exit in this case allowing the top level bookmark to be retrieved.

BUG=https://code.google.com/p/pdfium/issues/detail?id=110
R=bo_xu@foxitsoftware.com, tsepez@chromium.org

Review URL: https://codereview.chromium.org/847243005

fpdfsdk/src/fpdfdoc.cpp

index feb7cfb..41f5c8a 100644 (file)
@@ -29,7 +29,7 @@ static CPDF_Bookmark FindBookmark(const CPDF_BookmarkTree& tree, CPDF_Bookmark b
 
 DLLEXPORT FPDF_BOOKMARK STDCALL FPDFBookmark_GetFirstChild(FPDF_DOCUMENT document, FPDF_BOOKMARK pDict)
 {
-    if (!document || !pDict)
+    if (!document)
         return NULL;
     CPDF_Document* pDoc = (CPDF_Document*)document;
     CPDF_BookmarkTree tree(pDoc);