Add standard "Must be after no_chromium_code" comment in GN files.
authorLei Zhang <thestig@chromium.org>
Fri, 30 Oct 2015 17:31:03 +0000 (10:31 -0700)
committerLei Zhang <thestig@chromium.org>
Fri, 30 Oct 2015 17:31:03 +0000 (10:31 -0700)
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1411563004 .

BUILD.gn
third_party/BUILD.gn

index abd189b..6accde5 100644 (file)
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -554,8 +554,7 @@ static_library("fxge") {
   configs += [
     ":pdfium_config",
     "//build/config/compiler:no_chromium_code",
-    # As of this writing, this needs to be last to suppress a -Wswitch warning.
-    # https://crbug.com/547906
+    # Must be after no_chromium_code for warning flags to be ordered correctly.
     ":fxge_warnings",
   ]
 
index f635814..e9e50cd 100644 (file)
@@ -46,6 +46,7 @@ static_library("fx_freetype") {
   configs += [
     "//build/config/compiler:no_chromium_code",
     "//third_party/pdfium:pdfium_config",
+    # Must be after no_chromium_code for warning flags to be ordered correctly.
     ":fx_freetype_warnings",
   ]
   defines = [ "FT2_BUILD_LIBRARY" ]
@@ -95,6 +96,7 @@ source_set("fx_agg") {
   configs += [
     "//build/config/compiler:no_chromium_code",
     "//third_party/pdfium:pdfium_config",
+    # Must be after no_chromium_code for warning flags to be ordered correctly.
     ":fx_agg_warnings",
   ]
   sources = [
@@ -134,6 +136,7 @@ source_set("fx_lcms2") {
   configs += [
     "//build/config/compiler:no_chromium_code",
     "//third_party/pdfium:pdfium_config",
+    # Must be after no_chromium_code for warning flags to be ordered correctly.
     ":fx_lcms2_warnings",
   ]
   sources = [