Replace some Release() calls with virtual destructors.
authorTom Sepez <tsepez@chromium.org>
Wed, 17 Jun 2015 23:38:51 +0000 (16:38 -0700)
committerTom Sepez <tsepez@chromium.org>
Wed, 17 Jun 2015 23:38:51 +0000 (16:38 -0700)
commitff8347a4b16f000be628c5e10d03a1e1c17537eb
tree1d46e77a1ef6b28def6af3ffdd576017a6cfe229
parentc4d9f6ad2dc922b574862cd2f6f0a899d7e169e3
Replace some Release() calls with virtual destructors.

A virtual method that does |delete this| is an anti-pattern.
Some classes can be de-virtualized instead.
Throw in some unique_ptrs and delete dead code for good measure.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1192013002.
16 files changed:
core/include/fxcodec/fx_codec.h
core/include/fxcrt/fx_arb.h
core/include/fxge/fx_font.h
core/src/fpdfapi/fpdf_font/ttgsubtable.cpp
core/src/fpdfapi/fpdf_font/ttgsubtable.h
core/src/fpdftext/fpdf_text.cpp
core/src/fpdftext/fpdf_text_int.cpp
core/src/fxcodec/codec/fx_codec.cpp
core/src/fxcrt/fx_arabic.cpp
core/src/fxcrt/fx_arabic.h
fpdfsdk/include/fsdk_actionhandler.h
fpdfsdk/include/fsdk_baseform.h
fpdfsdk/src/fpdfview.cpp
fpdfsdk/src/fsdk_actionhandler.cpp
fpdfsdk/src/fsdk_baseform.cpp
fpdfsdk/src/fsdk_mgr.cpp