Revert "FX_BOOL considered harmful, part 2."
authorTom Sepez <tsepez@chromium.org>
Thu, 23 Jul 2015 20:36:00 +0000 (13:36 -0700)
committerTom Sepez <tsepez@chromium.org>
Thu, 23 Jul 2015 20:36:00 +0000 (13:36 -0700)
commitf1e7c461dfabbff6b65a072f24f6711b34159361
tree3b0bb772a59669f06b86824a444fd06642592d4b
parent320b2313d19869333ed453af546e61a9fc2b81c9
Revert "FX_BOOL considered harmful, part 2."

This reverts commit 320b2313d19869333ed453af546e61a9fc2b81c9.
Reason for revert: build failure.

TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/1255693002 .
299 files changed:
core/include/fdrm/fx_crypt.h
core/include/fpdfapi/fpdf_module.h
core/include/fpdfapi/fpdf_objects.h
core/include/fpdfapi/fpdf_page.h
core/include/fpdfapi/fpdf_pageobj.h
core/include/fpdfapi/fpdf_parser.h
core/include/fpdfapi/fpdf_render.h
core/include/fpdfapi/fpdf_resource.h
core/include/fpdfapi/fpdf_serial.h
core/include/fpdfdoc/fpdf_ap.h
core/include/fpdfdoc/fpdf_doc.h
core/include/fpdfdoc/fpdf_tagged.h
core/include/fpdfdoc/fpdf_vt.h
core/include/fpdftext/fpdf_text.h
core/include/fxcodec/fx_codec.h
core/include/fxcodec/fx_codec_provider.h
core/include/fxcrt/fx_arb.h
core/include/fxcrt/fx_basic.h
core/include/fxcrt/fx_coordinates.h
core/include/fxcrt/fx_ext.h
core/include/fxcrt/fx_stream.h
core/include/fxcrt/fx_string.h
core/include/fxcrt/fx_system.h
core/include/fxcrt/fx_ucd.h
core/include/fxcrt/fx_xml.h
core/include/fxge/fpf.h
core/include/fxge/fx_dib.h
core/include/fxge/fx_font.h
core/include/fxge/fx_ge.h
core/include/fxge/fx_ge_apple.h
core/include/fxge/fx_ge_win32.h
core/include/thirdparties/libjpeg/jmorecfg.h
core/include/thirdparties/libjpeg/jpegint.h
core/include/thirdparties/libjpeg/jpeglib.h
core/src/fdrm/crypto/fx_crypt.cpp
core/src/fdrm/crypto/fx_crypt_aes.cpp
core/src/fdrm/crypto/fx_crypt_sha.cpp
core/src/fpdfapi/fpdf_basic_module.cpp
core/src/fpdfapi/fpdf_edit/editint.h
core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp
core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp
core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp
core/src/fpdfapi/fpdf_font/font_int.h
core/src/fpdfapi/fpdf_font/fpdf_font.cpp
core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp
core/src/fpdfapi/fpdf_font/ttgsubtable.cpp
core/src/fpdfapi/fpdf_font/ttgsubtable.h
core/src/fpdfapi/fpdf_page/fpdf_page.cpp
core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp
core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp
core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp
core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp
core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp
core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp
core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp
core/src/fpdfapi/fpdf_page/pageint.h
core/src/fpdfapi/fpdf_parser/filters_int.h
core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp
core/src/fpdfapi/fpdf_render/fpdf_render.cpp
core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp
core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp
core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp
core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp
core/src/fpdfapi/fpdf_render/render_int.h
core/src/fpdfdoc/doc_action.cpp
core/src/fpdfdoc/doc_annot.cpp
core/src/fpdfdoc/doc_ap.cpp
core/src/fpdfdoc/doc_basic.cpp
core/src/fpdfdoc/doc_form.cpp
core/src/fpdfdoc/doc_formcontrol.cpp
core/src/fpdfdoc/doc_formfield.cpp
core/src/fpdfdoc/doc_metadata.cpp
core/src/fpdfdoc/doc_ocg.cpp
core/src/fpdfdoc/doc_tagged.cpp
core/src/fpdfdoc/doc_utils.cpp
core/src/fpdfdoc/doc_utils.h
core/src/fpdfdoc/doc_viewerPreferences.cpp
core/src/fpdfdoc/doc_vt.cpp
core/src/fpdfdoc/pdf_vt.h
core/src/fpdfdoc/tagged_int.h
core/src/fpdftext/fpdf_text.cpp
core/src/fpdftext/fpdf_text_int.cpp
core/src/fpdftext/fpdf_text_search.cpp
core/src/fpdftext/text_int.h
core/src/fpdftext/txtproc.h
core/src/fxcodec/codec/codec_int.h
core/src/fxcodec/codec/fx_codec.cpp
core/src/fxcodec/codec/fx_codec_fax.cpp
core/src/fxcodec/codec/fx_codec_flate.cpp
core/src/fxcodec/codec/fx_codec_icc.cpp
core/src/fxcodec/codec/fx_codec_jbig.cpp
core/src/fxcodec/codec/fx_codec_jpeg.cpp
core/src/fxcodec/codec/fx_codec_jpx_opj.cpp
core/src/fxcodec/jbig2/JBig2_BitStream.h
core/src/fxcodec/jbig2/JBig2_Context.cpp
core/src/fxcodec/jbig2/JBig2_Context.h
core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp
core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h
core/src/fxcodec/jbig2/JBig2_HuffmanTable.cpp
core/src/fxcodec/jbig2/JBig2_HuffmanTable.h
core/src/fxcodec/jbig2/JBig2_HuffmanTable_Standard.h
core/src/fxcodec/jbig2/JBig2_Image.cpp
core/src/fxcodec/jbig2/JBig2_Image.h
core/src/fxcodec/jbig2/JBig2_Page.h
core/src/fxcodec/jbig2/JBig2_SymbolDict.cpp
core/src/fxcodec/jbig2/JBig2_SymbolDict.h
core/src/fxcrt/extension.h
core/src/fxcrt/fx_arabic.cpp
core/src/fxcrt/fx_arabic.h
core/src/fxcrt/fx_basic_array.cpp
core/src/fxcrt/fx_basic_bstring.cpp
core/src/fxcrt/fx_basic_buffer.cpp
core/src/fxcrt/fx_basic_coords.cpp
core/src/fxcrt/fx_basic_gcc.cpp
core/src/fxcrt/fx_basic_maps.cpp
core/src/fxcrt/fx_basic_util.cpp
core/src/fxcrt/fx_basic_wstring.cpp
core/src/fxcrt/fx_extension.cpp
core/src/fxcrt/fx_unicode.cpp
core/src/fxcrt/fx_xml_parser.cpp
core/src/fxcrt/fxcrt_platforms.cpp
core/src/fxcrt/fxcrt_platforms.h
core/src/fxcrt/fxcrt_posix.cpp
core/src/fxcrt/fxcrt_posix.h
core/src/fxcrt/fxcrt_windows.cpp
core/src/fxcrt/fxcrt_windows.h
core/src/fxcrt/xml_int.h
core/src/fxge/agg/include/fx_agg_driver.h
core/src/fxge/agg/src/fx_agg_driver.cpp
core/src/fxge/android/fpf_skiafont.cpp
core/src/fxge/android/fpf_skiafont.h
core/src/fxge/android/fpf_skiafontmgr.cpp
core/src/fxge/android/fpf_skiafontmgr.h
core/src/fxge/android/fx_android_font.cpp
core/src/fxge/android/fx_android_font.h
core/src/fxge/apple/apple_int.h
core/src/fxge/apple/fx_apple_platform.cpp
core/src/fxge/apple/fx_mac_imp.cpp
core/src/fxge/apple/fx_quartz_device.cpp
core/src/fxge/dib/dib_int.h
core/src/fxge/dib/fx_dib_composite.cpp
core/src/fxge/dib/fx_dib_convert.cpp
core/src/fxge/dib/fx_dib_engine.cpp
core/src/fxge/dib/fx_dib_main.cpp
core/src/fxge/dib/fx_dib_transform.cpp
core/src/fxge/ge/fx_ge_device.cpp
core/src/fxge/ge/fx_ge_font.cpp
core/src/fxge/ge/fx_ge_fontmap.cpp
core/src/fxge/ge/fx_ge_linux.cpp
core/src/fxge/ge/fx_ge_path.cpp
core/src/fxge/ge/fx_ge_ps.cpp
core/src/fxge/ge/fx_ge_text.cpp
core/src/fxge/ge/text_int.h
core/src/fxge/skia/fx_skia_blitter_new.cpp
core/src/fxge/skia/fx_skia_blitter_new.h
core/src/fxge/skia/fx_skia_device.cpp
core/src/fxge/skia/fx_skia_device.h
core/src/fxge/win32/dwrite_int.h
core/src/fxge/win32/fx_win32_device.cpp
core/src/fxge/win32/fx_win32_dib.cpp
core/src/fxge/win32/fx_win32_dwrite.cpp
core/src/fxge/win32/fx_win32_gdipext.cpp
core/src/fxge/win32/fx_win32_print.cpp
core/src/fxge/win32/win32_int.h
fpdfsdk/include/formfiller/FFL_CheckBox.h
fpdfsdk/include/formfiller/FFL_ComboBox.h
fpdfsdk/include/formfiller/FFL_FormFiller.h
fpdfsdk/include/formfiller/FFL_IFormFiller.h
fpdfsdk/include/formfiller/FFL_ListBox.h
fpdfsdk/include/formfiller/FFL_Notify.h
fpdfsdk/include/formfiller/FFL_PushButton.h
fpdfsdk/include/formfiller/FFL_RadioButton.h
fpdfsdk/include/formfiller/FFL_TextField.h
fpdfsdk/include/formfiller/FFL_Utils.h
fpdfsdk/include/fsdk_actionhandler.h
fpdfsdk/include/fsdk_annothandler.h
fpdfsdk/include/fsdk_baseannot.h
fpdfsdk/include/fsdk_baseform.h
fpdfsdk/include/fsdk_define.h
fpdfsdk/include/fsdk_mgr.h
fpdfsdk/include/fsdk_rendercontext.h
fpdfsdk/include/fx_systemhandler.h
fpdfsdk/include/fxedit/fx_edit.h
fpdfsdk/include/fxedit/fxet_edit.h
fpdfsdk/include/fxedit/fxet_list.h
fpdfsdk/include/javascript/Document.h
fpdfsdk/include/javascript/Field.h
fpdfsdk/include/javascript/IJavaScript.h
fpdfsdk/include/javascript/Icon.h
fpdfsdk/include/javascript/JS_Context.h
fpdfsdk/include/javascript/JS_Define.h
fpdfsdk/include/javascript/JS_EventHandler.h
fpdfsdk/include/javascript/JS_GlobalData.h
fpdfsdk/include/javascript/JS_Object.h
fpdfsdk/include/javascript/JS_Runtime.h
fpdfsdk/include/javascript/JS_Value.h
fpdfsdk/include/javascript/PublicMethods.h
fpdfsdk/include/javascript/app.h
fpdfsdk/include/javascript/color.h
fpdfsdk/include/javascript/console.h
fpdfsdk/include/javascript/event.h
fpdfsdk/include/javascript/global.h
fpdfsdk/include/javascript/report.h
fpdfsdk/include/javascript/util.h
fpdfsdk/include/pdfwindow/PWL_Button.h
fpdfsdk/include/pdfwindow/PWL_Caret.h
fpdfsdk/include/pdfwindow/PWL_ComboBox.h
fpdfsdk/include/pdfwindow/PWL_Edit.h
fpdfsdk/include/pdfwindow/PWL_EditCtrl.h
fpdfsdk/include/pdfwindow/PWL_FontMap.h
fpdfsdk/include/pdfwindow/PWL_Icon.h
fpdfsdk/include/pdfwindow/PWL_IconList.h
fpdfsdk/include/pdfwindow/PWL_ListBox.h
fpdfsdk/include/pdfwindow/PWL_ListCtrl.h
fpdfsdk/include/pdfwindow/PWL_Note.h
fpdfsdk/include/pdfwindow/PWL_ScrollBar.h
fpdfsdk/include/pdfwindow/PWL_Signature.h
fpdfsdk/include/pdfwindow/PWL_SpecialButton.h
fpdfsdk/include/pdfwindow/PWL_Utils.h
fpdfsdk/include/pdfwindow/PWL_Wnd.h
fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp
fpdfsdk/src/formfiller/FFL_CheckBox.cpp
fpdfsdk/src/formfiller/FFL_ComboBox.cpp
fpdfsdk/src/formfiller/FFL_FormFiller.cpp
fpdfsdk/src/formfiller/FFL_IFormFiller.cpp
fpdfsdk/src/formfiller/FFL_ListBox.cpp
fpdfsdk/src/formfiller/FFL_Notify.cpp
fpdfsdk/src/formfiller/FFL_PushButton.cpp
fpdfsdk/src/formfiller/FFL_RadioButton.cpp
fpdfsdk/src/formfiller/FFL_TextField.cpp
fpdfsdk/src/formfiller/FFL_Utils.cpp
fpdfsdk/src/fpdf_dataavail.cpp
fpdfsdk/src/fpdf_ext.cpp
fpdfsdk/src/fpdf_flatten.cpp
fpdfsdk/src/fpdf_progressive.cpp
fpdfsdk/src/fpdf_sysfontinfo.cpp
fpdfsdk/src/fpdf_transformpage.cpp
fpdfsdk/src/fpdfdoc.cpp
fpdfsdk/src/fpdfeditimg.cpp
fpdfsdk/src/fpdfeditpage.cpp
fpdfsdk/src/fpdfformfill.cpp
fpdfsdk/src/fpdfppo.cpp
fpdfsdk/src/fpdfsave.cpp
fpdfsdk/src/fpdftext.cpp
fpdfsdk/src/fpdfview.cpp
fpdfsdk/src/fsdk_actionhandler.cpp
fpdfsdk/src/fsdk_annothandler.cpp
fpdfsdk/src/fsdk_baseannot.cpp
fpdfsdk/src/fsdk_baseform.cpp
fpdfsdk/src/fsdk_mgr.cpp
fpdfsdk/src/fsdk_rendercontext.cpp
fpdfsdk/src/fxedit/fxet_ap.cpp
fpdfsdk/src/fxedit/fxet_edit.cpp
fpdfsdk/src/fxedit/fxet_list.cpp
fpdfsdk/src/fxedit/fxet_pageobjs.cpp
fpdfsdk/src/javascript/Document.cpp
fpdfsdk/src/javascript/Field.cpp
fpdfsdk/src/javascript/Icon.cpp
fpdfsdk/src/javascript/JS_Context.cpp
fpdfsdk/src/javascript/JS_EventHandler.cpp
fpdfsdk/src/javascript/JS_GlobalData.cpp
fpdfsdk/src/javascript/JS_Runtime.cpp
fpdfsdk/src/javascript/JS_Value.cpp
fpdfsdk/src/javascript/PublicMethods.cpp
fpdfsdk/src/javascript/app.cpp
fpdfsdk/src/javascript/color.cpp
fpdfsdk/src/javascript/console.cpp
fpdfsdk/src/javascript/event.cpp
fpdfsdk/src/javascript/global.cpp
fpdfsdk/src/javascript/report.cpp
fpdfsdk/src/javascript/util.cpp
fpdfsdk/src/jsapi/fxjs_v8.cpp
fpdfsdk/src/pdfwindow/PWL_Button.cpp
fpdfsdk/src/pdfwindow/PWL_Caret.cpp
fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp
fpdfsdk/src/pdfwindow/PWL_Edit.cpp
fpdfsdk/src/pdfwindow/PWL_EditCtrl.cpp
fpdfsdk/src/pdfwindow/PWL_FontMap.cpp
fpdfsdk/src/pdfwindow/PWL_Icon.cpp
fpdfsdk/src/pdfwindow/PWL_IconList.cpp
fpdfsdk/src/pdfwindow/PWL_Label.cpp
fpdfsdk/src/pdfwindow/PWL_ListBox.cpp
fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp
fpdfsdk/src/pdfwindow/PWL_Note.cpp
fpdfsdk/src/pdfwindow/PWL_ScrollBar.cpp
fpdfsdk/src/pdfwindow/PWL_Signature.cpp
fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp
fpdfsdk/src/pdfwindow/PWL_Utils.cpp
fpdfsdk/src/pdfwindow/PWL_Wnd.cpp