Attempt to fix some -Woverloaded-virtual warnings.
authorNico Weber <thakis@chromium.org>
Wed, 30 Jul 2014 21:17:19 +0000 (14:17 -0700)
committerNico Weber <thakis@chromium.org>
Wed, 30 Jul 2014 21:17:19 +0000 (14:17 -0700)
commitf1d18bbda1099d9423e09ba4714b3712c1b512d3
treefbf7b4e497c72925263d7a7685b7b9c1c114fdec
parentfe08482976fb43cc93e4f8a3ea799d98dfe96ada
Attempt to fix some -Woverloaded-virtual warnings.

There are many warnings that look like:

error: 'CPWL_RadioButton::OnChar' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
        virtual FX_BOOL                         OnChar(FX_WORD nChar);
                                                ^
note: hidden overloaded virtual function 'CPWL_Wnd::OnChar' declared here: different number of parameters (2 vs 1)
        virtual FX_BOOL                                 OnChar(FX_WORD nChar, FX_DWORD nFlag);
                                                        ^

It looks like someone added the nFlag parameter to the methods in CPWL_Wnd
at some point and missed to update all overloads This patch attempts to fix this:
It adds the parameter to all methods that look like they're trying to overload the base
class method, and renames the method in one case where it fairly clearly looks like
that it's not supposed to be an overload.

BUG=pdfium:29
R=bo_xu@foxitsoftware.com

Review URL: https://codereview.chromium.org/416383004
fpdfsdk/include/pdfwindow/PWL_ComboBox.h
fpdfsdk/include/pdfwindow/PWL_IconList.h
fpdfsdk/include/pdfwindow/PWL_SpecialButton.h
fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp
fpdfsdk/src/pdfwindow/PWL_IconList.cpp
fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp