Remove unused nParamNum values from JS method tables.
authorTom Sepez <tsepez@chromium.org>
Fri, 24 Apr 2015 00:50:57 +0000 (17:50 -0700)
committerTom Sepez <tsepez@chromium.org>
Fri, 24 Apr 2015 00:50:57 +0000 (17:50 -0700)
commitef25d9995e494bd596ffea8fb8c09c2e48daa9a0
tree53e22c58375eb36abe97f5b8f2631b4eba111fbc
parente4fde52cc2c827e637c96e8e1f76ba4644cf718a
Remove unused nParamNum values from JS method tables.

The code to validate the number of parameters happens inside each particular
method, rather than prior to method dispatch. As such, there's no point in
having this number take up space in the table.

Add some test to cover at least some of the per-method validations, and
update error messages to be more useful.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1084183008
16 files changed:
fpdfsdk/include/javascript/JS_Define.h
fpdfsdk/include/javascript/resource.h
fpdfsdk/include/jsapi/fxjs_v8.h
fpdfsdk/src/javascript/Document.cpp
fpdfsdk/src/javascript/Field.cpp
fpdfsdk/src/javascript/PublicMethods.cpp
fpdfsdk/src/javascript/app.cpp
fpdfsdk/src/javascript/color.cpp
fpdfsdk/src/javascript/console.cpp
fpdfsdk/src/javascript/global.cpp
fpdfsdk/src/javascript/report.cpp
fpdfsdk/src/javascript/resource.cpp
fpdfsdk/src/javascript/util.cpp
fpdfsdk/src/jsapi/fxjs_v8.cpp
testing/resources/javascript/document_methods.in [new file with mode: 0644]
testing/resources/javascript/document_methods_expected.txt [new file with mode: 0644]