XFA: Manual merge of Clean up IFX_BidiChar
authorLei Zhang <thestig@chromium.org>
Thu, 29 Oct 2015 22:01:55 +0000 (15:01 -0700)
committerLei Zhang <thestig@chromium.org>
Thu, 29 Oct 2015 22:01:55 +0000 (15:01 -0700)
commitee02ea37e8f85920885600d56df706d690e648ff
tree055bbc66a5c95a8bc75ccc491f73505bb8eb6676
parent5a88b1131c450dee0500a02f80f0838385e4c4d2
XFA: Manual merge of Clean up IFX_BidiChar

- Replace IFX_BidiChar with just CFX_BidiChar
- Document implementation
- Change out parameters to pointers
- Remove dead code
- Add an enum for bidi directions
- Move several externs to a header
- Add unit tests

Original CL: https://codereview.chromium.org/1197643002

This version does not remove fx_arb.h and fx_arabic.h, as there is code
on the XFA branch that still uses parts of it.

R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1423103002 .
13 files changed:
BUILD.gn
core/include/fxcrt/fx_arb.h
core/include/fxcrt/fx_bidi.h [new file with mode: 0644]
core/include/fxcrt/fx_ucd.h
core/src/fpdftext/fpdf_text.cpp
core/src/fpdftext/fpdf_text_int.cpp
core/src/fpdftext/text_int.h
core/src/fxcrt/fx_arabic.cpp
core/src/fxcrt/fx_arabic.h
core/src/fxcrt/fx_bidi.cpp [new file with mode: 0644]
core/src/fxcrt/fx_bidi_unittest.cpp [new file with mode: 0644]
core/src/fxcrt/fx_unicode.cpp
pdfium.gyp