XFA: contention between FXJSE and FXJS over isolate data slots
authorTom Sepez <tsepez@chromium.org>
Tue, 22 Sep 2015 15:36:17 +0000 (08:36 -0700)
committerTom Sepez <tsepez@chromium.org>
Tue, 22 Sep 2015 15:36:17 +0000 (08:36 -0700)
commited7b2b50aa1744e0bc5a60bef12c61fa91d863b7
tree8661329f66b823af324441fb6accec98a8753cb8
parent854a7f65b70d40225a53890a68a57f5c13cf268c
XFA: contention between FXJSE and FXJS over isolate data slots

This probably broke at 06b60021e when the FXJS slot moved to 0
from 1 unless explicitly overriden by the embedder, which conflicted
with the FXJSE_ usage of slot 0.

Also simplify some logic used to track global intialization of the
underling JS.

TEST=run_javascript_tests.py on XFA branch doesn't segv.
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1351173002 .
fpdfsdk/include/fpdfxfa/fpdfxfa_app.h
fpdfsdk/include/javascript/JS_Define.h
fpdfsdk/include/jsapi/fxjs_v8.h
fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp
fpdfsdk/src/fsdk_mgr.cpp
fpdfsdk/src/javascript/JS_Runtime.cpp
fpdfsdk/src/jsapi/fxjs_v8.cpp
fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp
xfa/src/fxjse/src/runtime.cpp