Adding constructor to _FX_SYSTEMTIME to resolve uninitialized read bugs found by...
authorTom Sepez <tsepez@chromium.org>
Thu, 6 Nov 2014 22:38:12 +0000 (14:38 -0800)
committerTom Sepez <tsepez@chromium.org>
Thu, 6 Nov 2014 22:38:12 +0000 (14:38 -0800)
commitd9ecee1065cf391979dee0051b53fb5ff729ca2e
treea96ed4d3577f8415a31f7c26751329587fc41a42
parent173f919d0ec99a1a973c9d3a82b474f761d5bce1
Adding constructor to _FX_SYSTEMTIME to resolve uninitialized read bugs found by /analyze on some error paths

Warning from /analyze was:
src\third_party\pdfium\fpdfsdk\include\fsdk_mgr.h(96) : warning C6001: Using uninitialized memory 'fxtime'.

Other error paths can also lead to reading from an uninitialized _FX_SYSTEMTIME object.

Code-gen for the constructor is small enough (four writes of zeroed EAX with VC++, less with gcc) to make putting the constructor in a .cc file unnecessary.

Approval of in-class member initialization would make this fix simpler but that has not quite been approved yet.

BUG=https://code.google.com/p/pdfium/issues/detail?id=70
BUG=427616
R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/692533005
fpdfsdk/include/fx_systemhandler.h