Fix subtle issues in opj_skip_from_memory and add unit tests.
authorTom Sepez <tsepez@chromium.org>
Thu, 19 Mar 2015 19:51:04 +0000 (12:51 -0700)
committerTom Sepez <tsepez@chromium.org>
Thu, 19 Mar 2015 19:51:04 +0000 (12:51 -0700)
commitd1f792ac1ba25494b44e664d4a427127299d05e6
tree0cdfa5e28c1c7df416b1cd531f9a4450668f5a91
parent74b81d9ff8b4c4c5306b8c4611ee780ea0628c52
Fix subtle issues in opj_skip_from_memory and add unit tests.

Follow on to https://codereview.chromium.org/990683002/.
This more closely mimics what fseek() actually does, so as
to avoid subtle bugs down the road.

Move the DecodeData struct into a header so the test can
use it, and provide a constructor for it.

Along the way, I added include guards, removed the p_
prefix from some non-pointer vars, fixed some IWYU, and
resolved some signed/unsigned comparison warnings with
careful casting.

BUG=452671
R=jun_fang@foxitsoftware.com, thestig@chromium.org

Review URL: https://codereview.chromium.org/1016203002
BUILD.gn
core/src/fxcodec/codec/codec_int.h
core/src/fxcodec/codec/fx_codec_jpx_opj.cpp
core/src/fxcodec/codec/fx_codec_jpx_unittest.cpp [new file with mode: 0644]
pdfium.gyp