Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this.
authorBruce Dawson <brucedawson@google.com>
Mon, 8 Dec 2014 21:10:02 +0000 (13:10 -0800)
committerBruce Dawson <brucedawson@google.com>
Mon, 8 Dec 2014 21:10:02 +0000 (13:10 -0800)
commitb69da0b96ffdad124efd1b48d51c617bb216a98e
tree61d7c0212eaf4998591d0b941bfceb5646778062
parent4b87f7b5f8fe26ee4869a21a8b0b4697cba51a93
Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this.

Since casts to FX_LPCWSTR have been shown to hide bugs I tried removing
more of them, targeting those places where a cast was used to force a
conversion from CFX_WideString to FX_LPCWSTR, replacing these casts with
calls to the newly added .c_str() function. This revealed two places
where the cast was hiding a bug -- where ->c_str() was required instead!

This removes ~33 FX_LPCWSTR casts and there are ~31 left, many of which
will go away in some future change.

Also includes this change:

Removing unnecessary casts from wchar_t* to wchar_t*, by various names.

Original patch from Bruce Dawson(brucedawson@chromium.org)

R=bo_xu@foxitsoftware.com, tsepez@chromium.org

Review URL: https://codereview.chromium.org/733693003
16 files changed:
core/include/fxcrt/fx_string.h
core/src/fpdfapi/fpdf_font/fpdf_font.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp
core/src/fpdfdoc/doc_form.cpp
core/src/fxcrt/fx_basic_bstring.cpp
core/src/fxcrt/fx_basic_buffer.cpp
core/src/fxcrt/fx_extension.cpp
core/src/fxcrt/fx_xml_parser.cpp
core/src/fxcrt/fxcrt_platforms.cpp
fpdfsdk/include/javascript/JS_Define.h
fpdfsdk/src/fsdk_baseform.cpp
fpdfsdk/src/javascript/Document.cpp
fpdfsdk/src/javascript/Field.cpp
fpdfsdk/src/javascript/PublicMethods.cpp
fpdfsdk/src/javascript/app.cpp
fpdfsdk/src/javascript/global.cpp