Revert "Make m_pShadingObj a CPDF_Stream instead of CPDF_Object."
authorDan Sinclair <dsinclair@chromium.org>
Mon, 26 Oct 2015 20:25:38 +0000 (16:25 -0400)
committerDan Sinclair <dsinclair@chromium.org>
Mon, 26 Oct 2015 20:25:38 +0000 (16:25 -0400)
commit95d25e4585358c74ae91c2ed5e08099ebbfdf24c
tree89207598714eda2da04af966a013c905a1c63dcf
parent85361b227ad6786d2aeef8409b79a8d077a26ee9
Revert "Make m_pShadingObj a CPDF_Stream instead of CPDF_Object."

There appear to be a bunch of corpus tests which fail with this change such
as FAILURE: shading1.pdf

This reverts commit 85361b227ad6786d2aeef8409b79a8d077a26ee9.

Make m_pShadingObj a CPDF_Stream instead of CPDF_Object.

This object is required to be a stream and was being converted as such. With
the new type checking this caused us to pass a nullptr where previously we'd
have, incorrectly, cast a CPDF_Dictionary to a CPDF_Stream.

This CL changes the m_pShadingObj to always be a CPDF_Stream. Then, we never
go down the bad code path because we check if m_pShadingObj is nullptr earlier
and bail out.

BUG=chromium:547706
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1414283003 .
BUILD.gn
core/include/fpdfapi/fpdf_resource.h
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp
core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp
core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp
core/src/fpdfapi/fpdf_render/fpdf_render_pattern_embeddertest.cpp [deleted file]
pdfium.gyp
testing/resources/bug_547706.in [deleted file]
testing/resources/bug_547706.pdf [deleted file]