Extern in .cpp files is a code smell.
authorTom Sepez <tsepez@chromium.org>
Wed, 19 Aug 2015 17:28:50 +0000 (10:28 -0700)
committerTom Sepez <tsepez@chromium.org>
Wed, 19 Aug 2015 17:28:50 +0000 (10:28 -0700)
commit71c15a5e6652952a94ba3a3ef7ac0392e3a06962
treec6983e985c49e4f30906082b73045db14d8cb481
parenta2b3ae23556fb2f1adbc008574f33bf365476af9
Extern in .cpp files is a code smell.

Part 1.  Move to headers so compiler can type check against
the definitions.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1299963002 .
33 files changed:
BUILD.gn
core/include/fpdfapi/fpdf_parser.h
core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
core/src/fpdfapi/fpdf_font/font_int.h
core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp
core/src/fpdftext/unicodenormalization.cpp
core/src/fpdftext/unicodenormalizationdata.cpp
core/src/fpdftext/unicodenormalizationdata.h [new file with mode: 0644]
core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c
core/src/fxge/fontdata/chromefontdata/FoxitFixed.c
core/src/fxge/fontdata/chromefontdata/FoxitFixedBold.c
core/src/fxge/fontdata/chromefontdata/FoxitFixedBoldItalic.c
core/src/fxge/fontdata/chromefontdata/FoxitFixedItalic.c
core/src/fxge/fontdata/chromefontdata/FoxitSans.c
core/src/fxge/fontdata/chromefontdata/FoxitSansBold.c
core/src/fxge/fontdata/chromefontdata/FoxitSansBoldItalic.c
core/src/fxge/fontdata/chromefontdata/FoxitSansItalic.c
core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c
core/src/fxge/fontdata/chromefontdata/FoxitSerif.c
core/src/fxge/fontdata/chromefontdata/FoxitSerifBold.c
core/src/fxge/fontdata/chromefontdata/FoxitSerifBoldItalic.c
core/src/fxge/fontdata/chromefontdata/FoxitSerifItalic.c
core/src/fxge/fontdata/chromefontdata/FoxitSerifMM.c
core/src/fxge/fontdata/chromefontdata/FoxitSymbol.c
core/src/fxge/fontdata/chromefontdata/chromefontdata.h [new file with mode: 0644]
core/src/fxge/ge/fx_ge_fontmap.cpp
fpdfsdk/include/fsdk_define.h
fpdfsdk/src/fpdf_dataavail.cpp
fpdfsdk/src/fpdftext.cpp
fpdfsdk/src/fpdfview.cpp
fpdfsdk/src/fsdk_mgr.cpp
fpdfsdk/src/javascript/global.cpp
pdfium.gyp