Make conversion between CPDF_Action and its dictionary explicit.
authorTom Sepez <tsepez@chromium.org>
Fri, 6 Mar 2015 00:30:09 +0000 (16:30 -0800)
committerTom Sepez <tsepez@chromium.org>
Fri, 6 Mar 2015 00:30:09 +0000 (16:30 -0800)
commit624b6c1e0fc6a5b0467061ef37b6db6856681afb
tree8b1083b0b3f167da7fa7747ab530a9b37dab44b7
parent61c25eebf5a0fcf44dd1a434c88f502a34073eac
Make conversion between CPDF_Action and its dictionary explicit.

Precursor to taking a second shot at cleaning up the FPDF_*
APIs.  A FPDF_Action is a CPDF_Dictionary, and a CPDF_Action
is a structure holding a FPDF_Action.  This goes against the
convention that FPDF_ types get cast to CPDF_* types, so we
want to make it clear where objects are getting constructed,
etc.

Also tidy fpdf_actionhandler.cpp because it bugs me.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/984773002
core/include/fpdfdoc/fpdf_doc.h
core/src/fpdfdoc/doc_action.cpp
core/src/fpdfdoc/doc_bookmark.cpp
core/src/fpdfdoc/doc_formcontrol.cpp
core/src/fpdfdoc/doc_link.cpp
fpdfsdk/src/fpdfdoc.cpp
fpdfsdk/src/fsdk_actionhandler.cpp
fpdfsdk/src/fsdk_baseannot.cpp
fpdfsdk/src/fsdk_baseform.cpp
fpdfsdk/src/fsdk_mgr.cpp