Fixed or silenced all warnings and turned on warnings-as-errors.
authorJohn Abd-El-Malek <jam@chromium.org>
Tue, 20 May 2014 21:34:30 +0000 (14:34 -0700)
committerJohn Abd-El-Malek <jam@chromium.org>
Tue, 20 May 2014 21:34:30 +0000 (14:34 -0700)
commit4db62f5d942a3a7be00bfb5711836ce9e2c89f4b
tree7b48dc24263826cffb45cccc889939e0621e90d6
parent2c4b0465c1b95016a75a5fa10abe0ebb73170ee6
Fixed or silenced all warnings and turned on warnings-as-errors.

- Silence -Wheader-hygiene warning on Clang. Between fx_agg_driver.cpp
and fxjs_v8.h there are hundreds or thousands of things that depend on
"using namespace", so it is best to just suppress this warning than
fix it.
- gzguts.h: Include unistd.h on all non-Windows platforms, not just
Apple platforms. Fixes implicit include warnings on Linux.
- Added parens to silence a warning about mixing && and ||.
- Removed a check if an enum is negative. Enums can be unsigned,
generating an always-false warning. The check isn't necessary.
- Removed some statements that are just names of variables that do
nothing.

BUG=375114

Patch by Matt Giuca <mgiuca@chromium.org>
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
core/src/fxcodec/fx_zlib/zlib_v128/gzguts.h
core/src/fxcodec/lcms2/lcms2-2.6/src/cmsplugin.c
core/src/fxge/agg/agg23/fx_agg_driver.cpp
core/src/fxge/fx_freetype/fxft2.5.01/src/sfnt/ttload.c
pdfium.gyp