XFA: merge patch from CL 792953005, fix most warnings
authorBruce Dawson <brucedawson@google.com>
Thu, 8 Jan 2015 19:47:49 +0000 (11:47 -0800)
committerBruce Dawson <brucedawson@google.com>
Thu, 8 Jan 2015 19:47:49 +0000 (11:47 -0800)
commit3f49aa3ba3e8ba2fcedc8e2e2a88f3b06efd52b9
tree02773586b1bb5372282bc0c30e31e7aedbb4f9a5
parent5d3a4c83fc0a41b6b04d8f7022a9db3bc04ba73e
XFA: merge patch from CL 792953005, fix most warnings

Includes fixes to XFA specific warnings -- benign truncations.
Bug https://code.google.com/p/pdfium/issues/detail?id=104
was filed to track changing types to avoid some truncations.

Resolve all but two VC++ build warnings in pdfium.

pdfium builds on Win32 have about 85 warnings (250 in the XFA
branch, totaling over 480 lines!), mostly from four lines in
a header file and a warning that should be disabled. This
change resolves all but two of them and turns on
warning-as-errors. Bugs have been filed for the two
remaining warnings:
https://code.google.com/p/pdfium/issues/detail?id=100
the 64-bit warnings:
https://code.google.com/p/pdfium/issues/detail?id=101
and the Linux warnings:
https://code.google.com/p/pdfium/issues/detail?id=102

The fix to the double->float truncation bugs will also
improve code-generation.

R=bo_xu@foxitsoftware.com, tsepez@chromium.org

Review URL: https://codereview.chromium.org/792953005

BUG= https://code.google.com/p/pdfium/issues/detail?id=100

Review URL: https://codereview.chromium.org/834413002
build/standalone.gypi
core/src/fpdftext/fpdf_text_int.cpp
fpdfsdk/include/fsdk_mgr.h
fpdfsdk/src/fpdfformfill.cpp
fpdfsdk/src/fsdk_mgr.cpp
pdfium.gyp
xfa/src/fxfa/src/parser/xfa_localevalue.cpp