Don't leave dangling pointer to out-of-scope local in CPDF_StreamContentParser::Parse.
authorTom Sepez <tsepez@chromium.org>
Tue, 14 Oct 2014 21:40:57 +0000 (14:40 -0700)
committerTom Sepez <tsepez@chromium.org>
Tue, 14 Oct 2014 21:40:57 +0000 (14:40 -0700)
commit35d720aff01c5ea778c16ac1e31c56f68490f10b
treebdc1fcfb0ff5bc9d48ab3fde4f996bd3fe4b6ecb
parent9776eca31c69dfa154e20b784a9df396b134758f
Don't leave dangling pointer to out-of-scope local in CPDF_StreamContentParser::Parse.

This is just a bit of defensive programming; I'm not sure the situation can
occur in the current code, but the following code is likely to set off a red
flag to anyone who reads it:
    CPDF_StreamParser syntax(pData, dwSize);
    m_pSyntax = &syntax;
since the extent of the local |syntax| is far less than the pointer member
|m_pSyntax|.  NULL it out before syntax goes out of scope.

R=jun_fang@foxitsoftware.com

Review URL: https://codereview.chromium.org/652063002
core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp